Fix Modern and Legacy Syntax Info Conversion#8271
Merged
Conversation
Efnilite
approved these changes
Nov 2, 2025
APickledWalrus
requested changes
Nov 3, 2025
Member
APickledWalrus
left a comment
There was a problem hiding this comment.
Overall looks pretty good
APickledWalrus
requested changes
Nov 3, 2025
Member
APickledWalrus
left a comment
There was a problem hiding this comment.
Needs internal annotations on all introduced constructors
sovdeeth
approved these changes
Nov 6, 2025
APickledWalrus
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When calling
SyntaxElementInfo.fromModernthe modern->legacy syntax info conversion doesn't account for some of the new features of the modern syntax info object, mainly instance suppliers. If the modern syntax info primarily uses a supplier for its instance creation and doesn't contain a nullary constructor, the conversion will throw an exception for not being able to find a valid constructor.Solution
This is fixed by storing a reference to the source (modern) syntax info and delegating the modern syntax info methods to it.
Testing Completed
Updated
EventSyntaxInfoTest.Supporting Information
N/A
Completes: none
Related: none