Expand the key API to allow for nested keys#8243
Merged
APickledWalrus merged 16 commits intodev/featurefrom Jan 1, 2026
Merged
Expand the key API to allow for nested keys#8243APickledWalrus merged 16 commits intodev/featurefrom
APickledWalrus merged 16 commits intodev/featurefrom
Conversation
sovdeeth
approved these changes
Nov 6, 2025
APickledWalrus
requested changes
Nov 9, 2025
Member
APickledWalrus
left a comment
There was a problem hiding this comment.
seems ok overall just a couple thoughts
APickledWalrus
approved these changes
Dec 22, 2025
Member
|
needs to re-add atomicboolean import |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are a few issues that this PR aims to address. Most notably, there is currently no straightforward way to pass entire list structures around. The other issues consist of a couple of minor bugs.
foo(keyed {_list1::*}, keyed {_list2::*})wherelist1andlist2both contain values corresponding to the same key) would throw an exception.alphabetically sorted list,reversed list,shuffled listorsorted listexpressions does not retain the list's indices.Solution
This PR introduces new method to get an expression's values recursively, along with a corresponding
recursiveexpression that makes use of that behavior. When combined with thekeyedexpression, it allows both keys and values to be returned recursively, allowing entire structures to passed around seamlessly between different contexts.Addressing the aforementioned issues:
Parameterclass that evaluates expressions with respect to the parameter's modifiers. This unfortunately makes Fix function parameters with default value as list causing error #8221 obsolete.indices of x in ascending/descending orderKeyProviderExpressioninto its own interface and implement it inExprAlphabetList,ExprReversedList,ExprShuffledListandExprSortedListTesting Completed
StructFunction.sk,ExprRecursive.sk,ExprAlphabetList.sk,ExprReversedList.sk,ExprShuffledList.sk,ExprSortedList.skand manual testingSupporting Information
Below is a complete example showing how various combinations behave:
Using functions:
Completes: #8220, #1419
Related: none