Fixes foreground service not stopped when app gets destroyed#40
Merged
Conversation
Using flutter plugin flutter_plugin_android_lifecycle we can register a listener for app destroy event. We have to do this logic in platform-specific code, since _channel.invokeMethod wont work on flutter side
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue is android-only.
Using flutter plugin flutter_plugin_android_lifecycle we can register a listener for app destroy event.
When app gets destroyed, we want the foregroundservice to stop. Otherwise wenn we reopen the app, the plugin cannot connect to the running service and gets buggy.
We have to do this logic in platform-specific code, since _channel.invokeMethod wont work on flutter side when trying to call stop via WidgetsBindingObserver. See issue flutter/flutter#65538 and related issue #21.