Skip to content

add property#194

Merged
SirRender00 merged 7 commits into
SirRender00:mainfrom
LucasColas:patch-1
Jul 4, 2023
Merged

add property#194
SirRender00 merged 7 commits into
SirRender00:mainfrom
LucasColas:patch-1

Conversation

@LucasColas

Copy link
Copy Markdown
Contributor

Hello,
I added a property for the attribute called action. I think it's useful.
Because sometimes you can need to have access to the last action. self._action is supposed to be encapsulated.

@LucasColas LucasColas requested a review from SirRender00 as a code owner May 24, 2023 06:00
@codecov

codecov Bot commented May 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #194 (6297d24) into main (23fe7c5) will decrease coverage by 0.56%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   91.52%   90.97%   -0.56%     
==========================================
  Files          18       18              
  Lines        1121     1174      +53     
==========================================
+ Hits         1026     1068      +42     
- Misses         95      106      +11     
Impacted Files Coverage Δ
texasholdem/game/game.py 93.16% <66.66%> (-1.18%) ⬇️

... and 1 file with indirect coverage changes

@SirRender00 SirRender00 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable 👍. You'll need to add a docstring on the function AND at the top of the class, you can add it to the attributes for the docstring of the class.

Comment thread texasholdem/game/game.py Outdated
LucasColas and others added 2 commits May 26, 2023 15:51
Co-authored-by: Evyn Machi <32499767+SirRender00@users.noreply.github.com>
@LucasColas

Copy link
Copy Markdown
Contributor Author

Sounds reasonable 👍. You'll need to add a docstring on the function AND at the top of the class, you can add it to the attributes for the docstring of the class.

Done.

@LucasColas

Copy link
Copy Markdown
Contributor Author

I still don't understand what's wrong with pylint...

Comment thread texasholdem/game/game.py Outdated
@SirRender00

Copy link
Copy Markdown
Owner

@LucasColas Also feel free to run pylint locally with poetry run pylint texasholdem/

Co-authored-by: Evyn Machi <32499767+SirRender00@users.noreply.github.com>
@SirRender00

Copy link
Copy Markdown
Owner

@LucasColas Looks like you have to run poetry run black . to format the code.

@LucasColas

Copy link
Copy Markdown
Contributor Author

I'll do it.

@LucasColas

Copy link
Copy Markdown
Contributor Author

To be honest, I don't really understand how to install poetry.

@LucasColas

Copy link
Copy Markdown
Contributor Author

Ok, I think I understood. I did a new commit.

@LucasColas LucasColas requested a review from SirRender00 July 1, 2023 06:20
@LucasColas

Copy link
Copy Markdown
Contributor Author

How to handle codecov ?

@SirRender00

Copy link
Copy Markdown
Owner

Ah yeah don't worry about codecov, I'll merge this in 👍

@SirRender00 SirRender00 merged commit 793a841 into SirRender00:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants