add property#194
Conversation
Codecov Report
@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 91.52% 90.97% -0.56%
==========================================
Files 18 18
Lines 1121 1174 +53
==========================================
+ Hits 1026 1068 +42
- Misses 95 106 +11
|
SirRender00
left a comment
There was a problem hiding this comment.
Sounds reasonable 👍. You'll need to add a docstring on the function AND at the top of the class, you can add it to the attributes for the docstring of the class.
Co-authored-by: Evyn Machi <32499767+SirRender00@users.noreply.github.com>
Done. |
|
I still don't understand what's wrong with pylint... |
|
@LucasColas Also feel free to run pylint locally with |
Co-authored-by: Evyn Machi <32499767+SirRender00@users.noreply.github.com>
|
@LucasColas Looks like you have to run |
|
I'll do it. |
|
To be honest, I don't really understand how to install poetry. |
|
Ok, I think I understood. I did a new commit. |
|
How to handle codecov ? |
|
Ah yeah don't worry about codecov, I'll merge this in 👍 |
Hello,
I added a property for the attribute called action. I think it's useful.
Because sometimes you can need to have access to the last action. self._action is supposed to be encapsulated.