Refactor to use scikit-build-core with installation script #2484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace computing version in python.
The SKBUILD conditional block is removed, and the Python component is always defined.
Have scikit-built-core use the Python installation target to build wheels and install SimpleITK Python from the build directory. This removed the setup.py and setuptools usage. Add scikit-build-Packaging.cmake file. Add separate CMake file to build Python testing environment
The configured pyproject.toml has hard coded build options based on the CMake confogiration of the SimpleITK project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the binary directory Python packaging scripts to use scikit-build-core and use the CMake installation script for the Python component to create the Python package.