Use CMake's ContentFetch for GoogleTest #2458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GTest::GTest was depricated since CMake version 3.20
9759ffe to
3481c45
Compare
Removed the Superbuild GTest external project and replaced with FetchContent in the SimpleITK core build. The superbuild only downloaded the source and the GTest source was added as a subdirectory. The FetchContent directly does this. Note: To use an installed version of GTest/Google Test GOOGLETEST_ROOT CMake variable should be set, previously GTEST_ROOT was expected to point to googletest source code.
3481c45 to
d3cc9a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the ExternalProject approach for GoogleTest/GTest with ContentFetch.
Now to support a custom location for GoogleTest, the CMake variable GOOGLETEST_ROOT should be passing to SimpleITK. This removed support for passing GTEST_ROOT to SimpleITK or SimpleITKSuperbuild.