Fixes for Dockerfiles used in the Package GHA workflow #2329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
blowekamp
commented
Jun 17, 2025
- Use portable preferred shell syntax to define a function
- Remove unused install.sh for docker images
- Fix the package docker files to not use pip cache
- Add missing python3-venv package for Doxygen
- Improve installation of docker packages
- Use LABEL for docker maintainer
The manrainer instruction has been depricated. https://docs.docker.com/reference/build-checks/maintainer-deprecated/
Follow best practices with doing an update before installing packages.
The python venv needs to be installed separately on linux systems.
Creating the pip cache directory was causing errors with python 3.14. Explicitly specify python 3.12, and disable using pip cache.
zivy
approved these changes
Jun 17, 2025
dave3d
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.