Add formal JSON schema #2310
Merged
Add formal JSON schema #2310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivy
requested changes
Jun 3, 2025
Member
zivy
left a comment
There was a problem hiding this comment.
In the "description" fields, some end with a period, some don't. Possibly make consistent, but can be ignored. Actual change requests are inline comments.
ExpandTemplateGenerator/simpleitk_filter_description.schema.json
Outdated
Show resolved
Hide resolved
ExpandTemplateGenerator/simpleitk_filter_description.schema.json
Outdated
Show resolved
Hide resolved
ExpandTemplateGenerator/simpleitk_filter_description.schema.json
Outdated
Show resolved
Hide resolved
ExpandTemplateGenerator/simpleitk_filter_description.schema.json
Outdated
Show resolved
Hide resolved
ExpandTemplateGenerator/simpleitk_filter_description.schema.json
Outdated
Show resolved
Hide resolved
37092de to
ec91eab
Compare
zivy
approved these changes
Jun 5, 2025
Also add pre-commit check for validation
The old name was not converted from PYTHON_VERSION_STRING when the CMake Python module was changed.
67ccc03 to
154230c
Compare
Use the new module to check for the jsonschema package
Add separate configuration variable for the python executable used to do json validation (jinja template expantion). Running the validation requires Python with the jsonschema module, if it's not unstalled then validation does not occour during the build process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre-commit json validation, and use script to validate json before the build process.