Skip to content

Conversation

@blowekamp
Copy link
Member

Add missing options to the ImageSeriesReader

Add missing options to the ImageSeriesReader
@blowekamp blowekamp changed the title Add ForceOrthogonalDirection and ReverseOrder options Add ForceOrthogonalDirection and ReverseOrder options - for release May 16, 2025
@blowekamp blowekamp marked this pull request as ready for review May 16, 2025 12:54
@blowekamp blowekamp requested review from dave3d and zivy May 16, 2025 12:54
@blowekamp
Copy link
Member Author

@zivy What do you think about back porting these changes to 2.4?

@zivy
Copy link
Member

zivy commented May 22, 2025

@blowekamp, I believe in SimpleITK 2.x we don't force the orthogonal axes, so as long as the default for this is False then it would be nice to have this functionality in the 2.x releases. Otherwise I would view this as a breaking change which should happen in 3.0 where changes are widely expected.

@blowekamp
Copy link
Member Author

@blowekamp, I believe in SimpleITK 2.x we don't force the orthogonal axes, so as long as the default for this is False then it would be nice to have this functionality in the 2.x releases. Otherwise I would view this as a breaking change which should happen in 3.0 where changes are widely expected.

This was not set in SimpleITK before, the default is true in ITK:
https://github.com/InsightSoftwareConsortium/ITK/blob/4c028be3ba0ed839702893e6057c51a50a83ed03/Modules/IO/ImageBase/include/itkImageSeriesReader.h#L207

So this patch does not change behavior.

@zivy
Copy link
Member

zivy commented May 22, 2025

Thanks for the clarification. Given that the behavior didn't change, then it would be great to have this functionality already in the 2.x version so that folks don't have to wait for 3.x to use it if they need this functionality.

@blowekamp blowekamp merged commit 2f12793 into SimpleITK:release May 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants