Skip to content

Conversation

@blowekamp
Copy link
Member

Some Set method and Execute methods return "self" by reference, allowing for chained functions. This has been removed because in some situations the returned object can become invalid. Additionally, this was not supported by SWIG, and was not in any wrapped languages.

@blowekamp blowekamp force-pushed the remove_return_self branch 5 times, most recently from ae6a906 to 3401005 Compare April 30, 2025 20:29
@kwrobot-v1
Copy link

kwrobot-v1 bot commented Apr 30, 2025

Errors:

  • Failed to reserve ref 3401005 for the merge request: invalid git ref: 'no such commit'.
  • Failed to run the checks: mr utilities error: failed to list commits of 34010054818a8cba98d49fc136ab39892bb859c0 for https://github.com/SimpleITK/SimpleITK/pull/2278: fatal: bad object 34010054818a8cba98d49fc136ab39892bb859c0 .

Some Set method and Execute methods return "self" by reference,
allowing for chained functions. This has been removed because in some
situations the returned object can become invalid. Additionally, this
was not supported by SWIG, and was not in any wrapped languages.
@blowekamp blowekamp force-pushed the remove_return_self branch from 3401005 to 801b2c1 Compare May 22, 2025 15:48
@blowekamp blowekamp marked this pull request as ready for review May 29, 2025 19:03
@blowekamp blowekamp requested a review from zivy May 29, 2025 19:04
@blowekamp blowekamp merged commit 9cee624 into SimpleITK:master May 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants