Use variadic template for function traits and bindings #2197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4241765 to
fc8791b
Compare
zivy
approved these changes
Oct 9, 2024
Member
Author
|
@N-Dekker Not asking for a review 😄 Just sharing a use a variadic templates for function trains and argument bindings. Feel free to comment if interested. |
fc8791b to
aa66fb0
Compare
Replace explict arity based fuction traits and usage in MemberFunctionFactoryBase. This is a breaking change to some typedefs of the FunctionTraits class, specifically the ArgumentType is now a templated typedef.
aa66fb0 to
22d79be
Compare
Collaborator
Cool, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace explict arity based fuction traits and usage in MemberFunctionFactoryBase.
This is a breaking change to some typedefs of the FunctionTraits class, specifically the ArgumentType is now a templated typedef.