Use constexpr statements over enable_if dispatched functions #2196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivy
approved these changes
Oct 8, 2024
N-Dekker
reviewed
Oct 8, 2024
blowekamp
commented
Oct 8, 2024
aeca49f to
0094e7e
Compare
Remove enable_if and reduce symbol size, and extra function calls.
Use std::apply for operation on tuple.
0094e7e to
1b170f4
Compare
Collaborator
|
@blowekamp I'm sorry I don't have time to review the entire PR thoroughly, but you don't need to wait for me. I very much like its direction, and I'm glad I could help with a few suggestions 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conventional if statements with "constexpr" is more readable than complicated enable_if statements. Additionally, the produced object files are smaller due to shorter symbols names.