STYLE: Fixes to the python examples for pylint #2178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivy
approved these changes
Aug 15, 2024
Member
zivy
left a comment
There was a problem hiding this comment.
Looks good.
Please make sure these examples are not referenced in the documentation rst files with line numbers that may have changed due to this PR and need to be updated.
Member
|
These are some old and unmaintained examples. The "Examples/Python/Documentation.rst" does not look like it is incorporated into ReadTheDocs. Also adding the docs strings to the files may change how the examples should would be rendered. |
blowekamp
approved these changes
Aug 15, 2024
Member
blowekamp
left a comment
There was a problem hiding this comment.
These changes do look like an improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.