Skip to content

Conversation

@jwj019
Copy link
Contributor

@jwj019 jwj019 commented Jul 12, 2024

This PR adds a self-hosted Github Runner mac-arm64 to the build workflow to support arm64 builds on MacOS.

Copy link
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash all commit together to cleanup the PR?

@jwj019 jwj019 closed this Aug 22, 2024
@jwj019 jwj019 reopened this Aug 22, 2024
@jwj019 jwj019 marked this pull request as ready for review August 22, 2024 16:53
@jwj019
Copy link
Contributor Author

jwj019 commented Aug 22, 2024

Comments addressed, and it looks like builds are still working correctly.

Copy link
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up the debug message.

This looks good and can be merged for further testing after the cleanup

@blowekamp
Copy link
Member

blowekamp commented Aug 26, 2024

@jwj019 There is a build issue with the "build and test"/continuous action:
https://open.cdash.org/viewBuildError.php?buildid=9860041

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

@blowekamp
Copy link
Member

@jwj019 Nice work!

@blowekamp blowekamp merged commit de3cbdb into SimpleITK:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants