Backport patches made in Slicer fork #2137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jcfr Let me know if these changes should be integrated or fixed up for improved Slicer compatibility. |
Contributor
|
For reference, see Slicer/Slicer@fb4342c in which the corresponding patch was integrated in |
jcfr
approved these changes
Jan 23, 2025
Contributor
jcfr
left a comment
There was a problem hiding this comment.
Those match the patches currently integrated in the Slicer fork of SimpleITK. See Slicer/SimpleITK@1236005...4328a91
zivy
approved these changes
Jan 23, 2025
Member
Author
|
I am going to rebase these changes onto the current release branch. |
Fixes the following error: ``` CMake Error at /path/to/cmake-3.22.2-linux-x86_64/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find Python (missing: Interpreter Development.Module) Call Stack (most recent call first): /path/to/cmake-3.22.2-linux-x86_64/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE) /path/to/cmake-3.22.2-linux-x86_64/share/cmake-3.22/Modules/FindPython.cmake:561 (find_package_handle_standard_args) Wrapping/Python/CMakeLists.txt:7 (find_package) ```
fbddbba to
c9f69a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.