fix: click dispatch does not trigger defaults

eps1lon · eps1lon · commit db63f6dd468f · 2020-01-23T22:51:39.000+01:00
diff --git a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationUserInteraction-test.js b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationUserInteraction-test.js
@@ -208,7 +208,7 @@ describe('ReactDOMServerIntegrationUserInteraction', () => {
         expect(e.checked).toBe(true);
 
         // simulate a user clicking.
-        e.dispatchEvent(new Event('click', {bubbles: true, cancelable: true}));
+        e.click();
 
         expect(changeCount).toBe(1);
         expect(e.checked).toBe(false);
diff --git a/packages/react-dom/src/events/__tests__/ChangeEventPlugin-test.internal.js b/packages/react-dom/src/events/__tests__/ChangeEventPlugin-test.internal.js
@@ -250,9 +250,7 @@ describe('ChangeEventPlugin', () => {
     input.checked = true;
     // Under the hood, uncheck the box so that the click will "check" it again.
     setUntrackedChecked.call(input, false);
-    input.dispatchEvent(
-      new MouseEvent('click', {bubbles: true, cancelable: true}),
-    );
+    input.click();
     expect(input.checked).toBe(true);
     // We don't expect a React event because at the time of the click, the real
     // checked value (true) was the same as the last recorded "current" value
@@ -261,7 +259,7 @@ describe('ChangeEventPlugin', () => {
 
     // However, simulating a normal click should fire a React event because the
     // real value (false) would have changed from the last tracked value (true).
-    input.dispatchEvent(new Event('click', {bubbles: true, cancelable: true}));
+    input.click();
     expect(called).toBe(1);
   });
 
@@ -315,24 +313,18 @@ describe('ChangeEventPlugin', () => {
     const option2 = div.childNodes[1];
 
     // Select first option.
-    option1.dispatchEvent(
-      new Event('click', {bubbles: true, cancelable: true}),
-    );
+    option1.click();
     expect(called1).toBe(1);
     expect(called2).toBe(0);
 
     // Select second option.
-    option2.dispatchEvent(
-      new Event('click', {bubbles: true, cancelable: true}),
-    );
+    option2.click();
     expect(called1).toBe(1);
     expect(called2).toBe(1);
 
     // Select the first option.
     // It should receive the React change event again.
-    option1.dispatchEvent(
-      new Event('click', {bubbles: true, cancelable: true}),
-    );
+    option1.click();
     expect(called1).toBe(2);
     expect(called2).toBe(1);
   });
diff --git a/packages/react-interactions/events/src/dom/__tests__/Input-test.internal.js b/packages/react-interactions/events/src/dom/__tests__/Input-test.internal.js
@@ -424,9 +424,7 @@ describe('Input event responder', () => {
 
       // However, simulating a normal click should fire a React event because the
       // real value (false) would have changed from the last tracked value (true).
-      ref.current.dispatchEvent(
-        new Event('click', {bubbles: true, cancelable: true}),
-      );
+      ref.current.click();
       expect(onChangeCalled).toBe(1);
       expect(onValueChangeCalled).toBe(1);
     });
@@ -534,28 +532,22 @@ describe('Input event responder', () => {
       const option2 = ref.current.childNodes[1];
 
       // Select first option.
-      option1.dispatchEvent(
-        new Event('click', {bubbles: true, cancelable: true}),
-      );
+      option1.click();
       expect(onChangeCalled1).toBe(1);
       expect(onValueChangeCalled1).toBe(1);
       expect(onChangeCalled2).toBe(0);
       expect(onValueChangeCalled2).toBe(0);
 
       // Select second option.
-      option2.dispatchEvent(
-        new Event('click', {bubbles: true, cancelable: true}),
-      );
+      option2.click();
       expect(onChangeCalled1).toBe(1);
       expect(onValueChangeCalled1).toBe(1);
       expect(onChangeCalled2).toBe(1);
       expect(onValueChangeCalled2).toBe(1);
 
       // Select the first option.
       // It should receive the React change event again.
-      option1.dispatchEvent(
-        new Event('click', {bubbles: true, cancelable: true}),
-      );
+      option1.click();
       expect(onChangeCalled1).toBe(2);
       expect(onValueChangeCalled1).toBe(2);
       expect(onChangeCalled2).toBe(1);
