Add serialization ignores to custom properties within the Exception class#83
Merged
Sija merged 3 commits intoSija:masterfrom Mar 6, 2021
stephendolan:patch-1
Merged
Add serialization ignores to custom properties within the Exception class#83Sija merged 3 commits intoSija:masterfrom stephendolan:patch-1
Sija merged 3 commits intoSija:masterfrom
stephendolan:patch-1
Conversation
Closes #82, which can be viewed for more detail
Sija
reviewed
Mar 4, 2021
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Contributor
Author
|
Odd... it seems like the fork branch logic you're using in the CI for fork pull requests may not be working as expected, @Sija. I've had lots of trouble figuring out the glob patterns in my own repos as well, but if you have guidance I'm happy to include that update in my PR. |
Owner
|
@stephendolan I'd happily accept a (separate) PR with a fix, thanks! :) In the meantime I've removed this filter altogether to get CI working. |
Sija
reviewed
Mar 5, 2021
Owner
|
@stephendolan Thanks! ❤️ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82, which can be viewed for more detail.
I've tested this by running the LuckyCasts repo against this patch branch without the workaround code in place, and the application successfully compiles on my branch and errors out against the master branch.