OutOfBodyExperience - removing IFrame from body#3806
Conversation
See commit c920082 by moozzyk on Aug 13, 2014 foreverFrame was moved to documentElement however stop was still looking for it in the body. End result was connection was disposed but frame survived causing null reference errors to be thrown. Fixes SignalR#2795
|
Hi @jp9506, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
This is a good find. Thanks! |
|
Can you add a test for this (or update the existing test)? |
|
Unfortunately I am not familiar enough with github/test environment/etc. to be able to do that. Bug was found in our production environment which is implementing a method similar to the one found here: I was able to replicate the problem by disabling my LAN connection. Once the connection was re-enabled, the reconnect code worked but the javascript console was logging an error every 10 sec on the frame that wasn't removed. Given the unreliable connectivity of our user-base this spiraled out of control fairly quickly. |
|
OK. I added the test. Thanks! |
See commit c920082 by moozzyk on Aug 13, 2014
foreverFrame was moved to documentElement however stop was still looking for it in the body. End result was connection was disposed but frame survived causing null reference errors to be thrown.
Fixes #2795