EMB and Pluto Barycenter#97
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 8 8
Lines 2904 2914 +10
Branches 561 561
=======================================
+ Hits 2894 2904 +10
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For most planetary systems, there isn't much of a difference between the position of the planet center and the planetary system barycenter, since either the planet has no significant satellites, or else they are tiny compared to the planet itself.
The Earth-Moon system, and the Pluto system are the exceptions to the rule. In these systems the satellites have more comparable mass to the planet, and hence the planet center is significantly offset from the system's barycenter.
Until now, NOVAS did not distinguish between Earth vs Earth-Moon Barycenter (EMB) or Pluto (planet) vs Pluto system. But planetary ephemeris providers, such as the DExxx ephemeris data from JPL do make that distrinction. Hence expand
enum novas_planetto include the Earth-Moon Barycenter (NOVAS_EMB) and the Pluto system (NOVAS_PLUTO_BARYCENTER). As such the macroNOVAS_PLANETSis increased by 2 also.Various planet enum related macros in
novas.h(such asNOVAS_PLANET_NAMES_INIT) have also gained new members.