Skip to content

Orbital elements based calculations#96

Merged
attipaci merged 7 commits into
mainfrom
orbital-elements
Nov 15, 2024
Merged

Orbital elements based calculations#96
attipaci merged 7 commits into
mainfrom
orbital-elements

Conversation

@attipaci

@attipaci attipaci commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Added

  • NOVAS_ORBITAL_OBJECT to enum novas_planet.
  • novas_orbital_elements structure, including novas_orbital_system substructure, and enum novas_reference_plane to distiguish ecliptic vs equatorial orbital parameters, and novas_set_orbital_pole() helper function to configure.
  • object.orbit field containing novas_orbital_elements data
  • novas_orbit_posvel() function to calculate position and velocity vectors from orbital elements.
  • make_orbital_object() function to ease the creation of objects with orbital parameters.

Changed

  • ephemeris() call to process NOVAS_ORBITAL_OBJECT types via novas_orbit_posvel().

@attipaci attipaci added the enhancement New feature or request label Nov 13, 2024
@attipaci attipaci added this to the 1.2.0 milestone Nov 13, 2024
@attipaci attipaci self-assigned this Nov 13, 2024
@attipaci attipaci linked an issue Nov 13, 2024 that may be closed by this pull request
Add orbital elements processing #95
Closed
@codecov

codecov Bot commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (1e3d54e) to head (15911b9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   99.65%   99.70%   +0.04%     
==========================================
  Files           8        8              
  Lines        2914     3024     +110     
  Branches      561      575      +14     
==========================================
+ Hits         2904     3015     +111     
+ Partials       10        9       -1
Flag Coverage Δ
unittests 99.70% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/frames.c 99.52% <ø> (ø)
src/novas.c 99.62% <100.00%> (+0.07%) ⬆️
src/super.c 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3d54e...15911b9. Read the comment docs.

@attipaci attipaci force-pushed the orbital-elements branch 13 times, most recently from 87afc50 to c89e624 Compare November 14, 2024 10:44
@attipaci attipaci force-pushed the orbital-elements branch 3 times, most recently from 6b2ac27 to e34b056 Compare November 14, 2024 12:44
@attipaci attipaci changed the title Orbital element based calculations Orbital elements based calculations Nov 14, 2024
github-advanced-security[bot]
github-advanced-security AI found potential problems Nov 15, 2024
View reviewed changes
Comment thread src/novas.c Fixed
@attipaci attipaci force-pushed the orbital-elements branch 4 times, most recently from 027fbd6 to 70c911f Compare November 15, 2024 12:29
@attipaci attipaci marked this pull request as ready for review November 15, 2024 12:33
@attipaci attipaci merged commit b321692 into main Nov 15, 2024
@attipaci attipaci deleted the orbital-elements branch November 15, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@attipaci attipaci

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

Add orbital elements processing

2 participants

@attipaci @github-advanced-security