Skip to content

Initialize object.orbit where it is safe or document otherwise.#329

Merged
attipaci merged 1 commit into
mainfrom
orbit-init
May 20, 2026
Merged

Initialize object.orbit where it is safe or document otherwise.#329
attipaci merged 1 commit into
mainfrom
orbit-init

Conversation

@attipaci

Copy link
Copy Markdown
Collaborator
  • Initialize the orbit in make_cat_object_sys(), make_redshifted_object(), make_redshifted_object_sys(), all of which came at the same time or after the orbit field was introduced. Hence they are always safe to use.
  • Document other make_[...]() object initializers to note that they do not initialize the orbit fields with zeroes for back-compatibility reasons.

@attipaci attipaci added this to the 1.7.0 milestone May 20, 2026
@attipaci attipaci self-assigned this May 20, 2026
@attipaci attipaci added documentation Improvements or additions to documentation enhancement New feature or request labels May 20, 2026
@coveralls

coveralls commented May 20, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 26147516474

Warning

No base build found for commit 80b947b on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 98.874%

Details

  • Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 16252
Covered Lines: 16069
Line Coverage: 98.87%
Coverage Strength: 23116.85 hits per line

💛 - Coveralls

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@attipaci attipaci marked this pull request as ready for review May 20, 2026 07:34
@attipaci attipaci merged commit e99f203 into main May 20, 2026
28 checks passed
@attipaci attipaci deleted the orbit-init branch May 20, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make_cat_object / make_planet / make_ephem_object leave object.orbit uninitialized

2 participants