Skip to content

Annotate old functions to avoid with deprecated attribute#323

Merged
attipaci merged 1 commit into
mainfrom
annotate-deprecated
May 18, 2026
Merged

Annotate old functions to avoid with deprecated attribute#323
attipaci merged 1 commit into
mainfrom
annotate-deprecated

Conversation

@attipaci

@attipaci attipaci commented May 17, 2026

Copy link
Copy Markdown
Collaborator

While the Doxygen documentation mentions which old NOVAS C functions have been deprecated, there are a few functions that should be more actively discouraged. Adding annotations for these deprecated functions will result in compiler warnings to bring attention to the more questionable bits of the old API.

@attipaci attipaci added this to the 1.7.0 milestone May 17, 2026
@attipaci attipaci self-assigned this May 17, 2026
@attipaci attipaci added the enhancement New feature or request label May 17, 2026
@codecov

codecov Bot commented May 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coveralls

coveralls commented May 17, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 26022643602

Warning

No base build found for commit 3238376 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 99.124%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 9819
Covered Lines: 9733
Line Coverage: 99.12%
Coverage Strength: 38146.49 hits per line

💛 - Coveralls

@attipaci attipaci force-pushed the annotate-deprecated branch 14 times, most recently from 62d45fc to 00b2f64 Compare May 18, 2026 08:10
@attipaci attipaci marked this pull request as ready for review May 18, 2026 08:12
@attipaci attipaci force-pushed the annotate-deprecated branch 6 times, most recently from bb32e34 to 8eacb40 Compare May 18, 2026 08:30
@attipaci attipaci force-pushed the annotate-deprecated branch from 8eacb40 to 7c916cc Compare May 18, 2026 08:36
@attipaci attipaci merged commit ec60389 into main May 18, 2026
28 checks passed
@attipaci attipaci deleted the annotate-deprecated branch May 18, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants