Interferometric projections and more...#289
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Pull Request Test Coverage Report for Build 23941274990Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
187617f to
4966761
Compare
e42dad7 to
80712ba
Compare
ce60e0d to
832d686
Compare
4eea388 to
27d777f
Compare
168c835 to
2b3cc76
Compare
bd49b16 to
1e72b3c
Compare
d99a380 to
b848b88
Compare
69aee94 to
7434a6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C99 API
Added
novas_site_uvw()function to calculate geocentric interferometric projections for a site (anon_surfacestructure) around a line of sight (a.k.a. phase center).novas_uvw()function for more generalized calculations of interferometric projections.geo_posvel()is imprecise for Earth-based observers #306: Addednovas_site_gcrs_posvel()for calculating more accurate GCRS position / velocity vectors for Earth-based observers.Changed
geo_posvel()is imprecise for Earth-based observers #306:novas_make_frame()now uses the newnovas_site_gcrs_posvel()when calculating SSB-based observer position and velocity for Earth-based geodetic locations.<stdio.h>.C++ API
Added
Interferometricclass to handle interferometric u, v, w projections and to supply geometric delays along the line of sight.Observer::to_interferometric()method to convert an observer location to an interferometric projection around an observed line of sight for the array reference location.AstrometricPosition::to_interferometric()method to convert a relative station position (w.r.t. the array reference) to an interferometric projection along a line-of-sight, with precision, such as for space-based interferometers located far from Earth.Scalarabstract base class for scalar quantities.SolarSystemSource::barycentric_at()to get geometric positions velocities w.r.t. the SSB.Changed
Vector::x(),y(),z()toPositionandVelocityclasses with scalar return values.Weather::guess(Site&)toSite::average_weather(), for simplicity.