Export core target without re-naming#273
Merged
Merged
Conversation
27bca58 to
d5a051b
Compare
3d1e40f to
bce0022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coretarget was exported with another name ofsupernovas, causing the CMAke package config to fail, since it was expecting asupernovas::coretarget, but instead gotsupernovas::supernovas. Fixed by exportingcorewithout renaming.Also:
Removed unnecessary
POSITION_INDEPENDENT_CODEfromCMakeLists.txt. (It's automatic for shared libraries.)Removed
CLEAN_DIRECT_OUTPUTfromCMakeLists.txt. It's an option that is no longer needed or used (since 2009).Updated
README.mdinstructions for usingsupernovasCMake package.