Skip to content

Export core target without re-naming#273

Merged
attipaci merged 3 commits into
mainfrom
cmake-package-targets
Nov 16, 2025
Merged

Export core target without re-naming#273
attipaci merged 3 commits into
mainfrom
cmake-package-targets

Conversation

@attipaci

@attipaci attipaci commented Nov 16, 2025

Copy link
Copy Markdown
Collaborator
  • The core target was exported with another name of supernovas, causing the CMAke package config to fail, since it was expecting a supernovas::core target, but instead got supernovas::supernovas. Fixed by exporting core without renaming.

Also:

  • Removed unnecessary POSITION_INDEPENDENT_CODE from CMakeLists.txt. (It's automatic for shared libraries.)

  • Removed CLEAN_DIRECT_OUTPUT from CMakeLists.txt. It's an option that is no longer needed or used (since 2009).

  • Updated README.md instructions for using supernovas CMake package.

@attipaci attipaci added this to the 1.5.1 milestone Nov 16, 2025
@attipaci attipaci self-assigned this Nov 16, 2025
@attipaci attipaci added the bug Something isn't working label Nov 16, 2025
@attipaci attipaci linked an issue Nov 16, 2025 that may be closed by this pull request
@attipaci attipaci force-pushed the cmake-package-targets branch from 27bca58 to d5a051b Compare November 16, 2025 17:38
@attipaci attipaci force-pushed the cmake-package-targets branch from 3d1e40f to bce0022 Compare November 16, 2025 19:29
@attipaci attipaci marked this pull request as ready for review November 16, 2025 19:52
@attipaci attipaci merged commit e4204a9 into main Nov 16, 2025
12 checks passed
@attipaci attipaci deleted the cmake-package-targets branch November 16, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake / vcpkg configuring issue

1 participant