pthread mutexes instead of POSIX semaphores in plugins#263
Merged
Conversation
f48c6b2 to
7438508
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 24 24
Lines 4578 4578
Branches 902 902
=======================================
Hits 4571 4571
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
f3aab3b to
febe7ab
Compare
febe7ab to
67b5bde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pthread mutexes instead of POSIX semaphores in the CALCEPH and CSPICE plugins, for better portability. POSIX semaphores are not supported on Windows, nor on MacOS. As such the current CALCEPH and CSPICE plugins cannot be built for those platforms. But pthread is supported on all, including Windows (via an appropriate wrapper library -- which CMake configures as needed).