Don't build legacy solsys going forward#252
Merged
Merged
Conversation
9ffcc10 to
e9cf596
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 24 24
Lines 4557 4563 +6
Branches 894 894
=======================================
+ Hits 4551 4557 +6
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
26918f1 to
6e8b1c3
Compare
934a801 to
6362655
Compare
6362655 to
17ed076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy
solarsystem()providers (solsys1.c/eph_manager.c, andsolsys2.c), should no longer form an integral part of SuperNOVAS. Thus far, they have been built as separate add-on (plugin) modules, but even that is an overkill. There is no good reason for using these outdated and limited functionality modules in future application development.For legacy applications that require a
solarsystem()/solarsystem_hp()implementation from these as the default planetary ephemeris provider, you may use the newSOLSYS_SOURCEbuild configuration option (GNU make only) to build SuperNOVAS in that way.