Skip to content

Define catalog sources step-by-step#239

Merged
attipaci merged 4 commits into
mainfrom
ez-cat-entry
Sep 9, 2025
Merged

Define catalog sources step-by-step#239
attipaci merged 4 commits into
mainfrom
ez-cat-entry

Conversation

@attipaci

@attipaci attipaci commented Sep 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

New functions to define cat_entrydata step-by-step, and with more flexibility than the NOVAS C make_cat_entry()...

  1. Initialize the cat_entry with source name and RA/Dec coordinates using novas_init_cat_entry().
  2. (optional) Set radial velocity, as needed, via either:
    (a) radial velocity w.r.t SSB using novas_set_ssb_vel(), or
    (b) LSR velocity using novas_set_lsr_vel(), or
    (c) redshift using novas_set_redshift().
  3. (optional) Set proper motions (mas/yr), as needed, using novas_set_proper_motion().
  4. (optional) Set parallax, as needed, via either:
    (a) parallax (mas) using novas_set_parallax(), or
    (b) distance (parcsec) using novas_set_distance().
  5. (optional) Assign catalog info if desired via novas_set_catalog().

@attipaci attipaci added this to the 1.5.0 milestone Sep 8, 2025
@attipaci attipaci self-assigned this Sep 8, 2025
@attipaci attipaci added the enhancement New feature or request label Sep 8, 2025
@codecov

codecov Bot commented Sep 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (d06ee88) to head (31443c6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   99.89%   99.89%   -0.01%     
==========================================
  Files          24       24              
  Lines        4791     4552     -239     
  Branches      892      905      +13     
==========================================
- Hits         4786     4547     -239     
  Partials        5        5
Flag Coverage Δ
unittests 99.89% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/calendar.c 100.00% <100.00%> (ø)
src/frames.c 99.85% <100.00%> (+0.11%) ⬆️
src/parse.c 99.38% <100.00%> (-0.62%) ⬇️
src/spectral.c 100.00% <100.00%> (ø)
src/target.c 100.00% <100.00%> (ø)
src/timescale.c 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06ee88...31443c6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci force-pushed the ez-cat-entry branch 19 times, most recently from ca6c9f4 to 4187bfc Compare September 9, 2025 07:32
@attipaci attipaci marked this pull request as ready for review September 9, 2025 08:00
@attipaci attipaci merged commit 5db7a17 into main Sep 9, 2025
27 checks passed
@attipaci attipaci deleted the ez-cat-entry branch September 9, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@attipaci attipaci

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

1 participant

@attipaci