cmake: No additional compiler options by default#235
Merged
Conversation
4c63e9d to
09d5bb4
Compare
09d5bb4 to
f199191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake by default initializes
CMAKE_BUILD_TYPEas an empty string. Previously we defaulted it toRelease, which sets particular compiler options. However, in some cases we do not want to set extra compiler options. For example, Linux packagers typically want to control exactly what compiler options are used, which we should respect and not try to override. Thus, the default build type (empty string) is ideal for letting builders control exactly what compiler options should be used.Hence let the default build type be left undefined, with no additional compiler flags other than what was set in the
CFLAGSenvironment.