Skip to content

Diurnal EOP corrections for ocean tides and librations#215

Merged
attipaci merged 1 commit into
nextfrom
tides-and-librations
Aug 27, 2025
Merged

Diurnal EOP corrections for ocean tides and librations#215
attipaci merged 1 commit into
nextfrom
tides-and-librations

Conversation

@attipaci

@attipaci attipaci commented Aug 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

New functions to calculate diurnal and semi-diurnal corrections on top of the (interpolated) Earth orientation parameters (EOP) published by IERS. These corrections account for libration and the effect of ocean tides at periods of less than 2 days, and are necessary if calculating or using ITRS / TIRS coordinates with accuracies below a milli-arcsecond. The functions are based on the IERS Conventions v1.3, Chapters 5 and 8, and are verified with the test cases provided in the corresponding IERS fortran routines.

Added

int novas_diurnal_eop_at_time(const novas_timespec *restrict time, double *restrict dxp, double *restrict dyp, double *restrict dut1);

int novas_diurnal_eop(double gmst, const novas_delaunay_args *restrict delaunay, double *restrict xp, double *restrict yp, double *restrict dut1);

int novas_diurnal_libration(double gmst, const novas_delaunay_args *restrict delaunay, double *restrict xp, double *restrict yp, double *restrict dut1);

int novas_diurnal_ocean_tides(double gmst, const novas_delaunay_args *restrict delaunay, double *restrict xp, double *restrict yp, double *restrict dut1);

@attipaci attipaci added this to the 1.5.0 milestone Aug 24, 2025
@attipaci attipaci self-assigned this Aug 24, 2025
@attipaci attipaci added the enhancement New feature or request label Aug 24, 2025
@attipaci attipaci marked this pull request as draft August 24, 2025 12:27
@codecov

codecov Bot commented Aug 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (4da9418) to head (42b2a6f).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #215   +/-   ##
=======================================
  Coverage   99.88%   99.89%           
=======================================
  Files          23       23           
  Lines        4479     4549   +70     
  Branches      833      858   +25     
=======================================
+ Hits         4474     4544   +70     
  Partials        5        5
Flag Coverage Δ
unittests 99.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/earth.c 100.00% <100.00%> (ø)
src/equinox.c 100.00% <ø> (ø)
src/frames.c 99.73% <ø> (ø)
src/nutation.c 100.00% <ø> (ø)
src/timescale.c 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da9418...42b2a6f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci force-pushed the tides-and-librations branch 4 times, most recently from b962ac6 to 3625fbf Compare August 24, 2025 15:46
@attipaci attipaci mentioned this pull request Aug 24, 2025
Merged
@attipaci attipaci force-pushed the tides-and-librations branch 8 times, most recently from c0c799f to f428c9e Compare August 25, 2025 19:30
@attipaci attipaci marked this pull request as ready for review August 25, 2025 19:49
@attipaci attipaci force-pushed the tides-and-librations branch 10 times, most recently from 2e4f5f5 to c9175b4 Compare August 26, 2025 09:16
@attipaci attipaci force-pushed the tides-and-librations branch 3 times, most recently from e6d20e5 to 22d632a Compare August 26, 2025 20:56
@attipaci attipaci force-pushed the tides-and-librations branch from 22d632a to 42b2a6f Compare August 26, 2025 20:57
@attipaci attipaci changed the title EOP corrections for ocean tides and librations Diurnal EOP corrections for ocean tides and librations Aug 27, 2025
@attipaci attipaci merged commit b41952d into next Aug 27, 2025
14 checks passed
@attipaci attipaci deleted the tides-and-librations branch August 27, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@attipaci attipaci

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

1 participant

@attipaci