Skip to content

Use full struct names when embedding for C++ namespace.#193

Merged
attipaci merged 2 commits into
mainfrom
cpp-namespace
May 20, 2025
Merged

Use full struct names when embedding for C++ namespace.#193
attipaci merged 2 commits into
mainfrom
cpp-namespace

Conversation

@attipaci

Copy link
Copy Markdown
Collaborator

No description provided.

@attipaci attipaci added this to the 1.4.0 milestone May 19, 2025
@attipaci attipaci self-assigned this May 19, 2025
@attipaci attipaci added the enhancement New feature or request label May 19, 2025
@attipaci attipaci linked an issue May 19, 2025 that may be closed by this pull request
@codecov

codecov Bot commented May 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (3f67858) to head (4616093).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          23       23           
  Lines        4628     4628           
  Branches      861      861           
=======================================
  Hits         4624     4624           
  Partials        4        4           
Flag Coverage Δ
unittests 99.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f67858...4616093. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci mentioned this pull request May 19, 2025
@attipaci

Copy link
Copy Markdown
Collaborator Author

I did check this PR myself with an example program and g++ with -Wall -Wextra and it compiled without any errors/warnings and ran without any issues.

@attipaci attipaci marked this pull request as ready for review May 20, 2025 14:19
@attipaci attipaci merged commit 8ee1561 into main May 20, 2025
18 checks passed
@attipaci attipaci deleted the cpp-namespace branch May 20, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C++ namespace conflict

1 participant