Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 23 23
Lines 4519 4588 +69
Branches 840 851 +11
=======================================
+ Hits 4515 4584 +69
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
68f1d21 to
deeaa8d
Compare
49457e5 to
69ff1bd
Compare
99725d3 to
10dee7e
Compare
15b3601 to
80459a1
Compare
1123fd0 to
911149f
Compare
7e30a9c to
a29938f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the
enumto include reference systems that rotate with Earth, that is the Terrestrial Intermediate Reference System (TIRS; a pseudo Earth-fixed with no polar wobble corrections), and the International Terrestrial Reference System (ITRS; Earth-fixed). Both are IAU 2006 standard reference systems.Update all SuperNOVAS functions, which take reference systems as arguments to process the new additions. All frame-based calculations can process the added systems.
Note, however, that in case of the legacy
place(), and its variants, ITRS cannot be processed due to the lack of polar wobble parameters among the arguments passed, so these functions will return an error code if called withNOVAS_ITRSas the system. And orbitals must be defined in inertial systems, thus for these TIRS or ITRS will be rejected also.