Skip to content

cache nutation_angles() + module reorg#171

Merged
attipaci merged 6 commits into
mainfrom
caching_tweaks_4
Apr 21, 2025
Merged

cache nutation_angles() + module reorg#171
attipaci merged 6 commits into
mainfrom
caching_tweaks_4

Conversation

@attipaci

@attipaci attipaci commented Apr 21, 2025

Copy link
Copy Markdown
Collaborator

The caching changes result in significant performance boost in some usage scenarios. See updated benchmarks in the README.

Also:

  • Move precession(), nutation() and nutation_angles() to equinox.c.
  • Deprecate ee_ct() and ira_equinox(), both of which are meant for internal use, and not really useful for users in general.

@attipaci attipaci added the enhancement New feature or request label Apr 21, 2025
@attipaci attipaci added this to the 1.3.1 milestone Apr 21, 2025
@attipaci attipaci self-assigned this Apr 21, 2025
@attipaci attipaci force-pushed the caching_tweaks_4 branch 2 times, most recently from 09e8d55 to a1e46a9 Compare April 21, 2025 15:20
@codecov

codecov Bot commented Apr 21, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (c9ef354) to head (64bf81f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          22       22           
  Lines        4283     4285    +2     
  Branches      794      794           
=======================================
+ Hits         4279     4281    +2     
  Partials        4        4           
Flag Coverage Δ
unittests 99.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/earth.c 100.00% <100.00%> (ø)
src/equinox.c 100.00% <100.00%> (ø)
src/system.c 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ef354...64bf81f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci changed the title nutation_angles: add caching + some module reorg cache nutation_angles() + module reorg Apr 21, 2025
@attipaci attipaci marked this pull request as ready for review April 21, 2025 16:32
@attipaci attipaci merged commit ba69f64 into main Apr 21, 2025
@attipaci attipaci deleted the caching_tweaks_4 branch April 21, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant