Skip to content

parse_degrees() check invalid seconds#166

Merged
attipaci merged 3 commits into
mainfrom
parse_dms_invalid_seconds
Apr 15, 2025
Merged

parse_degrees() check invalid seconds#166
attipaci merged 3 commits into
mainfrom
parse_dms_invalid_seconds

Conversation

@attipaci

Copy link
Copy Markdown
Collaborator

Improved checking for invalid decimal seconds when parsing DSM angle strings.

@attipaci attipaci added the enhancement New feature or request label Apr 15, 2025
@attipaci attipaci added this to the 1.3.1 milestone Apr 15, 2025
@attipaci attipaci self-assigned this Apr 15, 2025
@codecov

codecov Bot commented Apr 15, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (e14e955) to head (002fe7f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   99.88%   99.90%   +0.02%     
==========================================
  Files          22       22              
  Lines        4268     4270       +2     
  Branches      789      790       +1     
==========================================
+ Hits         4263     4266       +3     
+ Partials        5        4       -1     
Flag Coverage Δ
unittests 99.90% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/parse.c 100.00% <100.00%> (+0.31%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14e955...002fe7f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci changed the title parse_dms() check invalid seconds parse_degrees() check invalid seconds Apr 15, 2025
@attipaci attipaci force-pushed the parse_dms_invalid_seconds branch from 776ed44 to 002fe7f Compare April 15, 2025 22:32
@attipaci attipaci marked this pull request as ready for review April 15, 2025 22:46
@attipaci attipaci merged commit 7f7312d into main Apr 15, 2025
@attipaci attipaci deleted the parse_dms_invalid_seconds branch April 15, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant