Skip to content

Timestamp duplicate seconds digit and rounding fixes#153

Merged
attipaci merged 5 commits into
mainfrom
issue-151
Apr 1, 2025
Merged

Timestamp duplicate seconds digit and rounding fixes#153
attipaci merged 5 commits into
mainfrom
issue-151

Conversation

@attipaci

@attipaci attipaci commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator
  • Fix extra digit when remainder seconds in the [0:10) range is rounded up to 10.
  • Fix rounding to nearest ms.
  • Fix possible rounding issue with date part

@attipaci attipaci added the bug Something isn't working label Apr 1, 2025
@attipaci attipaci added this to the 1.3.0 milestone Apr 1, 2025
@attipaci attipaci self-assigned this Apr 1, 2025
@attipaci attipaci linked an issue Apr 1, 2025 that may be closed by this pull request
@codecov

codecov Bot commented Apr 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (325505f) to head (7607e4c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          22       22           
  Lines        4169     4172    +3     
  Branches      778      779    +1     
=======================================
+ Hits         4165     4168    +3     
  Partials        4        4           
Flag Coverage Δ
unittests 99.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/timescale.c 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 325505f...7607e4c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci marked this pull request as ready for review April 1, 2025 10:11
@attipaci attipaci merged commit 39e87bc into main Apr 1, 2025
@attipaci attipaci deleted the issue-151 branch April 1, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect ISO timestamp formatting in some cases

1 participant