Skip to content

Fixes to rise/set/transit time calculations#141

Merged
attipaci merged 2 commits into
mainfrom
issue-140
Mar 8, 2025
Merged

Fixes to rise/set/transit time calculations#141
attipaci merged 2 commits into
mainfrom
issue-140

Conversation

@attipaci

@attipaci attipaci commented Mar 8, 2025

Copy link
Copy Markdown
Collaborator
  • Bad bracket placement in rise/set/transit time calculation caused times to be systematically off by minutes.
  • Also fix refraction unit.

@attipaci attipaci added the bug Something isn't working label Mar 8, 2025
@attipaci attipaci added this to the 1.3.0 milestone Mar 8, 2025
@attipaci attipaci self-assigned this Mar 8, 2025
@attipaci attipaci linked an issue Mar 8, 2025 that may be closed by this pull request
@attipaci attipaci marked this pull request as ready for review March 8, 2025 16:56
@codecov

codecov Bot commented Mar 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (c430348) to head (449cbac).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   99.90%   99.90%   -0.01%     
==========================================
  Files          22       22              
  Lines        4161     4160       -1     
  Branches      779      779              
==========================================
- Hits         4157     4156       -1     
  Partials        4        4              
Flag Coverage Δ
unittests 99.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/frames.c 99.71% <100.00%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c430348...449cbac. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci changed the title Fix bad bracketing in rise/set time Fixes to rise/set/transit time calculations Mar 8, 2025
@attipaci attipaci merged commit 933447a into main Mar 8, 2025
@attipaci attipaci deleted the issue-140 branch March 8, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rise/transit/set times calculation

1 participant