Since it's introduction in v1.1, novas_geom_posvel() returned a velocity vector referenced to the Solar-system Barycenter (SSB) instead of relative to the observer. The contract of the function was to return observer based velocities.
The bug did not have downstream effects within the library. The only library function to call novas_geom_posvel() and use velocities was novas_sky_pos(), which did correctly use the returned velocities as SSB-based.
To fix:
Since it's introduction in v1.1,
novas_geom_posvel()returned a velocity vector referenced to the Solar-system Barycenter (SSB) instead of relative to the observer. The contract of the function was to return observer based velocities.The bug did not have downstream effects within the library. The only library function to call
novas_geom_posvel()and use velocities wasnovas_sky_pos(), which did correctly use the returned velocities as SSB-based.To fix:
novas_geom_posvel()to conform to its contract and return observer based velocities.novas_sky_pos()to convert observer-based velocities to SSB-based velocities for calculating a radial velocity measure.