feat(fork): implement repository forking functionality in `gt new` by cedi · Pull Request #1442 · SierraSoftworks/git-tool

cedi · 2025-04-16T17:05:06Z

add 'from' argument to create a fork of an existing remote repository
add fork_repo method to GitHubService for forking repositories
create ForkRepository task to handle repository forking
update GitClone to use default struct initialization
implement GitAddRemote task for adding/removing git remotes
add tests for ForkRepository and GitAddRemote functionalities

- add 'from' argument to create a fork of an existing remote repository - add fork_repo method to GitHubService for forking repositories - create ForkRepository task to handle repository forking - update GitClone to use default struct initialization - implement GitAddRemote task for adding/removing git remotes - add tests for ForkRepository and GitAddRemote functionalities

codecov · 2025-04-16T17:07:59Z

Codecov Report

Attention: Patch coverage is 92.88256% with 20 lines in your changes missing coverage. Please review.

Project coverage is 85.49%. Comparing base (e46c2c6) to head (8a34799).
Report is 19 commits behind head on main.

Files with missing lines	Patch %	Lines
src/online/service/github.rs	76.47%	16 Missing ⚠️
src/tasks/fork_remote.rs	96.72%	2 Missing ⚠️
src/commands/clone.rs	50.00%	1 Missing ⚠️
src/commands/open.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
+ Coverage   85.28%   85.49%   +0.21%     
==========================================
  Files          97       98       +1     
  Lines        9889    10143     +254     
==========================================
+ Hits         8434     8672     +238     
- Misses       1455     1471      +16

Files with missing lines	Coverage Δ
src/commands/new.rs	`95.57% <100.00%> (+1.94%)`	⬆️
src/completion/completer.rs	`100.00% <100.00%> (ø)`
src/engine/features.rs	`100.00% <100.00%> (ø)`
src/online/service/mod.rs	`100.00% <ø> (ø)`
src/tasks/git_clone.rs	`100.00% <100.00%> (ø)`
src/tasks/git_remote.rs	`96.34% <100.00%> (+3.31%)`	⬆️
src/tasks/mod.rs	`58.53% <ø> (ø)`
src/commands/clone.rs	`86.66% <50.00%> (ø)`
src/commands/open.rs	`77.46% <0.00%> (ø)`
src/tasks/fork_remote.rs	`96.72% <96.72%> (ø)`
... and 1 more

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

notheotherben · 2025-04-16T17:24:17Z

        ];

+        if let Some(from_repo) = matches.get_one::<String>("from") {
+            let from_repo_id: Identifier = from_repo.as_str().parse()?;


I wonder whether we need to support --from https://github.com/... style remotes here (instead of just supporting valid identifiers). Presumably that would be a different codepath since it wouldn't support any of the remote fork workflows etc.

notheotherben · 2025-04-16T17:26:09Z

    async fn complete(&self, core: &Core, completer: &Completer, _matches: &ArgMatches) {
        completer.offer("--open");
        completer.offer("--no-create-remote");
+        completer.offer("--from");


I haven't checked, but we may want to look at completer and _matches to determine whether the current completion target is "whatever follows --from" and ensure we're suggesting full repo names in that case as well.

This isn't a big deal to be fair, but it could make for a nicer autocomplete experience.

github-actions · 2025-04-16T17:49:24Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T17:56:02Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T18:16:40Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T18:32:48Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T18:45:32Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T19:01:48Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T19:03:11Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T19:22:57Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T20:08:20Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T20:22:53Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T20:38:59Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T20:41:28Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T22:04:11Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

github-actions · 2025-04-16T22:05:26Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

…us cargo invocations which are failing to find libdbus during flake builds

github-actions · 2025-04-16T22:38:15Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-00ba9e303-1442.westeurope.1.azurestaticapps.net

fix organization

b9ef27a

notheotherben reviewed Apr 16, 2025

View reviewed changes

add docs

19ed7e3

fix unit-test

ac64407

cleanup

38a6d77

PR comments

3a8c9f9

fix unit-test for windows

3870270

wait for GitHub API to be ready

01952be

I like it fancier

408a120

simplify the forking logic

2685b20

notheotherben reviewed Apr 16, 2025

View reviewed changes

Comment thread src/commands/new.rs Outdated

notheotherben reviewed Apr 16, 2025

View reviewed changes

Comment thread src/engine/features.rs

notheotherben reviewed Apr 16, 2025

View reviewed changes

Comment thread src/online/service/github.rs Outdated

notheotherben reviewed Apr 16, 2025

View reviewed changes

Comment thread src/online/service/github.rs

notheotherben reviewed Apr 16, 2025

View reviewed changes

Comment thread src/tasks/fork_repo.rs

notheotherben reviewed Apr 16, 2025

View reviewed changes

Comment thread src/tasks/fork_repo.rs Outdated

wip

a344962

PR comments

2c68693

fix unit-tests

da1bbe8

fix outdated ubuntu

46ae2b6

github-actions bot added docs Changes to the documentation feature A new feature for Git-Tool labels Apr 16, 2025

style: Fix clippy errors

61fd68b

ci: Ensure that libdbus is available for code quality checks

05d375d

notheotherben enabled auto-merge April 16, 2025 22:04

notheotherben disabled auto-merge April 16, 2025 22:04

notheotherben added 2 commits April 16, 2025 23:26

ci: Ensure that we provide nativeBuildInputs and buildInputs to vario…

12b48b9

…us cargo invocations which are failing to find libdbus during flake builds

ci: Switch to a supported CI platform for the Tests Completed step

8a34799

notheotherben enabled auto-merge April 16, 2025 22:37

notheotherben merged commit 72a750b into main Apr 16, 2025
12 checks passed

notheotherben deleted the feature/support_for_forking branch April 16, 2025 22:39

Conversation

cedi commented Apr 16, 2025

Uh oh!

codecov bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

notheotherben Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

notheotherben Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Apr 16, 2025 •

edited

Loading