feat: Improve handling of missing git repo directory#1411
Merged
notheotherben merged 7 commits intomainfrom Mar 27, 2025
Merged
feat: Improve handling of missing git repo directory#1411notheotherben merged 7 commits intomainfrom
notheotherben merged 7 commits intomainfrom
Conversation
cedi
requested changes
Mar 27, 2025
Collaborator
cedi
left a comment
There was a problem hiding this comment.
LGTM - there are some build failures through that would need to be fixed.
Co-authored-by: cedi <cedi@users.noreply.github.com>
…rectory existence checks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
+ Coverage 84.51% 84.59% +0.07%
==========================================
Files 93 93
Lines 9416 9497 +81
==========================================
+ Hits 7958 8034 +76
- Misses 1458 1463 +5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logic to explicitly check the existence of a git repo directory before spawning a git command in said directory, allowing us to present better error messages to the user in these situations (instead of a generic
File not found (error code 2)error).