Skip to content

Add possibility to customize float border#130

Merged
SidOfc merged 2 commits intoSidOfc:masterfrom
FantomeBeignet:master
Aug 16, 2023
Merged

Add possibility to customize float border#130
SidOfc merged 2 commits intoSidOfc:masterfrom
FantomeBeignet:master

Conversation

@FantomeBeignet
Copy link
Copy Markdown
Contributor

This pull request adds the CarbonFloatBorder highlight group to allow customization of the floating explorer window's border

@SidOfc
Copy link
Copy Markdown
Owner

SidOfc commented Aug 16, 2023

Hello there @FantomeBeignet, Nice PR indeed, looks clean 👍
I do have one minor comment, currently FloatBorder is linked to just CarbonFloat but with this change, it will be linked to FloatBorder since that's the default value of CarbonFloatBorder.

Would you mind changing CarbonFloatBorder to link to CarbonFloat by default? This way updating won't cause a change in (highlight) behavior while still allowing users to customize it.

@SidOfc SidOfc self-assigned this Aug 16, 2023
@SidOfc SidOfc added the improvement Improvements or updates to existing features label Aug 16, 2023
@FantomeBeignet
Copy link
Copy Markdown
Contributor Author

Alright, I'll fix that up real quick

@SidOfc SidOfc merged commit 93f7d11 into SidOfc:master Aug 16, 2023
@SidOfc
Copy link
Copy Markdown
Owner

SidOfc commented Aug 16, 2023

Alrighty, merged and released as version 0.19.2, thank you very much for the quick fix and good thinking 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvements or updates to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants