Merged
Conversation
1ef635f to
3d779bc
Compare
3d779bc to
5659a13
Compare
dersam
approved these changes
Mar 3, 2026
Morriar
reviewed
Mar 4, 2026
| @@ -0,0 +1,33 @@ | |||
| # typed: false | |||
Contributor
There was a problem hiding this comment.
The rest of the project uses # typed: true or # typed: strong — any reason this one is # typed: false? I think we could bump it to # typed: true and add RBS-style signatures to the overridden methods, similar to how dont_expect_unexpected_nil.rb does it:
Suggested change
| # typed: false | |
| # typed: true |
| @@ -0,0 +1,33 @@ | |||
| # typed: false | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README says to use
plugins:but that doesn't actually work at the moment (you'd have to userequire:). This PR fixes that, following the instructions from: https://docs.rubocop.org/rubocop/latest/plugin_migration_guide.html