Fix dsl compiler for Google::Protobuf::RepeatedField #2406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the code comments:
The attribute accessors require
RepeatedFields but the initializer requires anArray.We intend to report the inconsistency to Google, but even if they fix it it won't work for older versions.
Do we want the output of tapioca to match what protobuf does now?
Or would we want to leave this as is if Google were to fix protobuf?