Translator to RBS only removes extend T::Helpers when needed
#751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
approved these changes
Jun 5, 2025
Comment on lines
+105
to
+114
| old_class_annotations = @class_annotations | ||
| @class_annotations = [] | ||
| old_type_members = @type_members | ||
| @type_members = [] | ||
| old_extend_t_helpers = @extend_t_helpers | ||
| @extend_t_helpers = [] | ||
| old_extend_t_generics = @extend_t_generics | ||
| @extend_t_generics = [] | ||
| old_seen_mixes_in_class_methods = @seen_mixes_in_class_methods | ||
| @seen_mixes_in_class_methods = false |
Member
There was a problem hiding this comment.
nit: Personally, I find this style easier to follow:
Suggested change
| old_class_annotations = @class_annotations | |
| @class_annotations = [] | |
| old_type_members = @type_members | |
| @type_members = [] | |
| old_extend_t_helpers = @extend_t_helpers | |
| @extend_t_helpers = [] | |
| old_extend_t_generics = @extend_t_generics | |
| @extend_t_generics = [] | |
| old_seen_mixes_in_class_methods = @seen_mixes_in_class_methods | |
| @seen_mixes_in_class_methods = false | |
| old_class_annotations, @class_annotations = @class_annotations, [] | |
| old_type_members, @type_members = @type_members, [] | |
| old_extend_t_helpers, @extend_t_helpers = @extend_t_helpers, [] | |
| old_extend_t_generics, @extend_t_generics = @extend_t_generics, [] | |
| old_seen_mixes_in_class_methods, @seen_mixes_in_class_methods = @seen_mixes_in_class_methods, false |
Contributor
Author
There was a problem hiding this comment.
I like it but Rubocop doesn't:
Member
There was a problem hiding this comment.
Ah no worries then it's good to ship already 👍
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, we shouldn't remove the
extend T::Helpersas we still need it formixes_in_class_methods: