Skip to content

Update REST resources with type fixes#1153

Merged
mkevinosullivan merged 1 commit intomainfrom
update_rest_resources_with_type_fixes
May 10, 2023
Merged

Update REST resources with type fixes#1153
mkevinosullivan merged 1 commit intomainfrom
update_rest_resources_with_type_fixes

Conversation

@mkevinosullivan
Copy link
Contributor

Description

Fixed various typing errors

Fixes #1152

How has this been tested?

REST resource generation in shopify-dev includes type checking test which passed for all of these.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • not applicable I have updated the project documentation.
  • I have added a changelog line.

Copy link
Contributor

@nelsonwittwer nelsonwittwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super excited to get all these generated fixes in! Thanks so much, @mkevinosullivan and @paulomarg for your help here!!!

@mkevinosullivan mkevinosullivan merged commit e260ef5 into main May 10, 2023
@mkevinosullivan mkevinosullivan deleted the update_rest_resources_with_type_fixes branch May 10, 2023 19:02
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems July 11, 2023 18:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessing the arguments property on a ShopifyAPI::Event object returns a Sorbet TypeError

2 participants