-
Notifications
You must be signed in to change notification settings - Fork 481
Closed
Description
Issue summary
When trying to access 'taxes_included' and 'tax_shipping' fields on the shop resource it fails because of the wrong sorbet type definition.
The Shopify documentation states that both fields should be booleans but in shop resource are defined as strings.
https://shopify.dev/docs/api/admin-rest/2023-04/resources/shop
Expected behavior
>shopify_shop.taxes_included
>true
>shopify_shop.tax_shipping
>true
Actual behavior
> shopify_shop.taxes_included
> TypeError (Return value: Expected type T.nilable(String), got type TrueClass)
> shopify_shop.tax_shipping
> TypeError (Return value: Expected type T.nilable(String), got type TrueClass)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels