Skip to content

REST API Shop resource definitions TypeError #1145

@LovroM

Description

@LovroM

Issue summary

When trying to access 'taxes_included' and 'tax_shipping' fields on the shop resource it fails because of the wrong sorbet type definition.
The Shopify documentation states that both fields should be booleans but in shop resource are defined as strings.
https://shopify.dev/docs/api/admin-rest/2023-04/resources/shop

Expected behavior

>shopify_shop.taxes_included
>true

>shopify_shop.tax_shipping
>true

Actual behavior

> shopify_shop.taxes_included
> TypeError (Return value: Expected type T.nilable(String), got type TrueClass)

> shopify_shop.tax_shipping
> TypeError (Return value: Expected type T.nilable(String), got type TrueClass)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions