Migrate to RBS signatures supported by Sorbet #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Using `spoom srb sigs translate` Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
KaanOzkan
approved these changes
Feb 21, 2025
|
|
||
| Layout/LineLength: | ||
| Max: 120 | ||
| AllowedPatterns: ['\A\s*#:'] |
Contributor
There was a problem hiding this comment.
Multiline support isn't here yet right? We should remember to clean these up.
Contributor
Author
There was a problem hiding this comment.
Even before we should clean those once the new Ruby style guide is released, I upstreamed those rules there 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs bump our Sorbet version to v0.5.11842 so we can start using RBS comment signatures instead of the
sig{}syntax 🎉I migrated all the signatures using
spoom srb sigs translate.Note that for the moment we're not translating signatures that contain
abstract.