Merged
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Chrome 120, the default headless is now a different binary, causing Selenium to fail to inject its extensions, we can't get logs, etc. See more in SeleniumHQ/selenium#13271
Instead of waiting for a new release of
selenium-webdriverthat includes the fix to continue using the old headless, or configuring Selenium to use an older version of Chrome, this moves to the new headless Chrome.I had two issues doing that:
Unfortunately the method seems deprecated in the Chrome DevTools Protocol: https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-setDownloadBehavior (permalink) but for now that should do it.
--headlessafter our--headless=new, so we were still seeing the problems with 6.0, I monkey-patched the problematic method.