Bump Rubocop TargetRubyVersion to 2.5 series#78
Merged
GustavoCaso merged 2 commits intomasterfrom Apr 20, 2021
Merged
Conversation
Ruby 2.4 is EOL and Rubocop has accordingly dropped their support. https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/ rubocop/rubocop#9648 https://github.com/rubocop/rubocop/blob/76bc0a0e026b13fccdc7b6bccfd6d082d24a7b52/CHANGELOG.md#1130-2021-04-20 The change to the TargetRubyVersion introduced a violation because of the redundant `begin`, which has been autocorrected.
1a8a890 to
c6441db
Compare
Member
|
Should we drop support to 2.4 in the gem? It is still allowed to be installed in 2.4 |
Since we no longer lint against 2.4 syntax, we should explicitly drop support for it.
Contributor
Author
|
Good idea @rafaelfranca. I just pushed a commit doing that. Hopefully that is the correct way to specify it? |
Contributor
Author
|
Though, it does occur to me: is dropping 2.4 support a breaking change, or is it "fine" because Ruby 2.4 is EOL? If we want to fix CI without dropping support, we'd have to add a restriction on the version of Rubocop in |
rafaelfranca
approved these changes
Apr 20, 2021
GustavoCaso
approved these changes
Apr 20, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 2.4 is EOL and Rubocop has accordingly dropped their support. This change fixes our CI.
Relevant Links