Add Ascension Island and Tristan da Cunha to countries list #123
Conversation
b2a89b0 to
6656edb
Compare
There was a problem hiding this comment.
This PR led me to learn so much about ISO 3166! Thanks for taking this on.
For bonus points: while reading this gem's description, I noticed this statement:
While most of the code in this library was extracted from ActiveMerchant, ActiveMerchant itself doesn't use this library anymore. For PCI compliance reasons, we aim to keep the number of dependencies of ActiveMerchant as low as possible. For this reason, many of these classes and modules are mirrored in ActiveMerchant (e.g. ActiveUtils::Connection vs. ActiveMerchant::Connection. When making changes to this library, you may want to mirror those changes in ActiveMerchant.
I searched the activemerchant codebase for a country.rb, and found that this code is indeed copied in that library as well. Would you mind porting your changes there as well?
Oh great catch! Yes, absolutely, can do! |
Adding Ascension Island and Tristan da Cunha to the countries list under the ISO3166-1 special case of keeping them separate from Saint Helena. Pulled alpha3 from https://en.wikipedia.org/wiki/ISO_3166-1_alpha-3, and alpha2 from https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2.
No numeric codes for AC and TA are listed at this time, example source https://en.wikipedia.org/wiki/ISO_3166-1_numeric, so left those blank for now.