This repository was archived by the owner on Aug 30, 2018. It is now read-only.
Add StorefrontExpressButtons.initialize in cartCallback#563
Merged
Conversation
Contributor
|
|
Contributor
Author
|
ping @Krystosterone |
|
❤️ |
Contributor
|
👍 |
Contributor
Author
|
I'm going to go ahead and merge this unless somebody has last minute objections :) |
Contributor
|
👍 |
|
@xuorig If I make no mistake you merged invalid Javascript here. Basically you close a } without opening it before unless I'm crazy here... |
Contributor
|
You're right.. and I gave it two 👍 .. I'll open a fix right now |
Contributor
Author
|
omg how did we miss this 🤦 thanks for the quick fix @cshold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Themes using
ajax-cartwith Amazon Payments button are currently broken because of the script tag inserted along with the button.Handlebars + script tag in template = 💥
Let's add a callback after the cart has been updated where we can initialize every button needed on storefront.
@Krystosterone @cshold please review 👯
Next step is modifying
shopify-themeswith these changes too. @cshold can you shed some light on the difference betweenajax-cart.jsandajaxify.jsinshopify-themes?dont merge until https://github.com/Shopify/shopify/pull/80604