Fix incorrect NASM install skipping logic. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Sibras merged 1 commit into ShiftMediaProject:master from tlaedre:fix-nasm-install-skip-logic

Jul 5, 2024

Contributor

tlaedre commented Jul 3, 2024

Fix two issues with the skip-NASM-install-if-exists-in-%NASMPATH%-logic:

Installing NASM binaries doesn't work at all (the use existing exe path is always taken, regardless of whether the env var is set or the exe exists).
The skip-install path is skipped if the nasm archive has been downloaded and exists on disk.


          Fix incorrect NASM install skipping logic.

547b535

Sibras merged commit c511e9a into ShiftMediaProject:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet